Skip to content

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Aug 17, 2023

This should fix a problem with the 3.7.0rc0 docs that was pointed out : the numbering of the lists of items in the whatsnew section was messed up by the insertion of anchor points for the 'feature items' para.

I think this fixes that.
We will include it in the main release, and in any subsequent bugfixes, but we won't make a bugfix release for this alone.
So for now, I'll include it here and, when this is agreed, it will also go into the v3.7.x mergeback to main.

@pp-mo pp-mo requested a review from HGWright August 17, 2023 16:33
@pp-mo
Copy link
Member Author

pp-mo commented Aug 17, 2023

Ping @HGWright please see what you think of this.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (75ff780) 89.37% compared to head (05a0e00) 89.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.7.x    #5427   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files          89       89           
  Lines       22443    22443           
  Branches     5381     5381           
=======================================
  Hits        20058    20058           
  Misses       1639     1639           
  Partials      746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo pp-mo mentioned this pull request Aug 17, 2023
2 tasks
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking out the RTD, the changes seem to have the desired effect so I'm happy to merge this.

@HGWright HGWright merged commit fccf9e6 into SciTools:v3.7.x Aug 18, 2023
@pp-mo pp-mo deleted the v3.7.x_PLUS branch August 31, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants