address concatenate lazy comparison truthiness #5353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3.6.x #5353 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 89 89
Lines 22398 22398
Branches 5375 5375
=======================================
Hits 20008 20008
Misses 1640 1640
Partials 750 750
☔ View full report in Codecov by Sentry. |
Member
Author
|
Ping @sloosvel, just so you're aware 👍 |
bjlittle
commented
Jun 18, 2023
bjlittle
commented
Jun 18, 2023
trexfeathers
requested changes
Jun 19, 2023
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks @bjlittle, this all makes sense to me.
A few changes to improve test readability:
trexfeathers
approved these changes
Jun 20, 2023
Member
Author
|
@trexfeathers Awesome, thanks 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR is a follow-on to #5142.
Lazy comparison will always yield a truthy value, therefore we require to realize the comparison. In this case, we're performing either lazy indexing for a single value or comparing lazy single values. Realizing the result won't undo the intent of #5142.
Great spot @trexfeathers 👀
To do:
as_concrete_datapattern, if possibleConsult Iris pull request check list