Skip to content

Conversation

@bjlittle
Copy link
Member

@bjlittle bjlittle commented Mar 31, 2023

🚀 Pull Request

Description

This PR is a follow-up to #4972, which introduces the use of dask.array.ma.empty_like to iris.

This feature was available from dask 2022.8.1.

I've set the min pin to be 2022.9.0, rather than the month point release.

Kudos to @rcomer who landed dask/dask#9378 🤟


Consult Iris pull request check list

@rcomer
Copy link
Member

rcomer commented Mar 31, 2023

Glad it’s come in useful. I wanted ones_like for another Iris branch but then changed my mind about how to do that one 😅

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ba3ac6d) 89.28% compared to head (06effa3) 89.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5225   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files          88       88           
  Lines       22269    22269           
  Branches     4870     4870           
=======================================
  Hits        19882    19882           
  Misses       1641     1641           
  Partials      746      746           
Impacted Files Coverage Δ
lib/iris/analysis/cartography.py 86.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rcomer
Copy link
Member

rcomer commented Mar 31, 2023

Though it looks like #4972 didn't actually use da.ma.empty_like because it's new - instead wrote a workaround.

@bjlittle
Copy link
Member Author

Though it looks like #4972 didn't actually use da.ma.empty_like because it's new - instead wrote a workaround.

Yup, spinning too many plates... forgot to replace the workaround, duh!

Inbound...

@bjlittle bjlittle requested a review from rcomer March 31, 2023 14:31
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I've learned something: you didn't used to be able to assign values to a slice of a dask array, but apparently now you can. Wonder when that changed...

@bjlittle did you want to add a whatsnew here?

@bjlittle
Copy link
Member Author

Well I've learned something: you didn't used to be able to assign values to a slice of a dask array, but apparently now you can. Wonder when that changed...

@bjlittle did you want to add a whatsnew here?

Seems to work, right?

Yeah, I'll add a quick entry in the whatsnew... inbound

@rcomer
Copy link
Member

rcomer commented Mar 31, 2023

Seems to work, right?

Sure does!

@rcomer rcomer merged commit 8786962 into SciTools:main Mar 31, 2023
@bjlittle
Copy link
Member Author

@rcomer Awesome, thanks 🥳

@bjlittle bjlittle deleted the raise-dask-min-pin branch April 3, 2023 10:54
HGWright added a commit to HGWright/iris that referenced this pull request Apr 3, 2023
* 'main' of github.com:SciTools/iris:
  Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227)
  raise dask min pin (SciTools#5225)
  Enable lazy computation of wind vector rotation (SciTools#4972)
@bjlittle bjlittle self-assigned this Apr 4, 2023
tkknight added a commit to tkknight/iris that referenced this pull request Apr 4, 2023
* upstream/main: (274 commits)
  Cf cell method (SciTools#5224)
  Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5230)
  Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227)
  raise dask min pin (SciTools#5225)
  Enable lazy computation of wind vector rotation (SciTools#4972)
  Benchmark runner script (SciTools#5215)
  add locks readme (SciTools#5222)
  use explicit version for ci refresh-lockfiles gha (SciTools#5221)
  SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220)
  Fix Makefile for consequences of SciTools#5204. (SciTools#5217)
  Bump actions/stale from 7 to 8 (SciTools#5208)
  Remove Iris' TestRunner (SciTools#5205)
  standardize requirements structure (SciTools#5204)
  Updated environment lockfiles (SciTools#5199)
  Add histogram convenience for passing Iris objects to plt.hist (SciTools#5189)
  Updated environment lockfiles (SciTools#5192)
  announce new contributor in whatsnew (SciTools#5198)
  iris.util.new_axis anonymous new dimension fix (SciTools#5194)
  Lockfiles and pydata-sphinx-theme fix (SciTools#5188)
  ...
tkknight added a commit to tkknight/iris that referenced this pull request Apr 13, 2023
* upstream/main: (59 commits)
  Updated environment lockfiles (SciTools#5211)
  update ci locks location (SciTools#5228)
  Fixes to _discontiguity_in_bounds (attempt 2) (SciTools#4975)
  Finalises Lazy Data documentation (SciTools#5137)
  Modernize and simplify iris.analysis._Groupby (SciTools#5015)
  clarity on whatsnew entry contributors (SciTools#5240)
  Handle derived coordinates correctly in `concatenate` (SciTools#5096)
  Use real array for data of of small netCDF variables. (SciTools#5229)
  Bump scitools/workflows from 2023.04.1 to 2023.04.2 (SciTools#5236)
  fixing whatsnew entry
  remove results creation commit from blame
  configure codecov
  adding a whatsnew entry
  Replacing numpy legacy printing with array2string and remaking results for dependent tests
  Adding a whatsnew entry for 5224 (SciTools#5234)
  Cf cell method (SciTools#5224)
  Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5230)
  Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227)
  raise dask min pin (SciTools#5225)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants