Skip to content

Switch order of options and parameter in ncgen command #5105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trexfeathers merged 2 commits into from
Dec 14, 2022
Merged

Switch order of options and parameter in ncgen command #5105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50969b3
switch order of options and parameter in ncgen
fnattino Dec 12, 2022
ba70bd2
add info to whatsnew
fnattino Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/src/whatsnew/latest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,15 @@ This document explains the changes made to Iris for this release
💼 Internal
===========

#. N/A
#. `@fnattino`_ changed the order of ``ncgen`` arguments in the command to
create NetCDF files for testing (caused errors on OS X). (:pull:`5105`)


.. comment
Whatsnew author names (@github name) in alphabetical order. Note that,
core dev names are automatically included by the common_links.inc:


.. _@fnattino: https://github.com/fnattino


.. comment
Expand Down
2 changes: 1 addition & 1 deletion lib/iris/tests/stock/netcdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def ncgen_from_cdl(
f_out.write(cdl_str)
if cdl_path:
# Create netcdf from stored CDL file.
call_args = [NCGEN_PATHSTR, cdl_path, "-k3", "-o", nc_path]
call_args = [NCGEN_PATHSTR, "-k3", "-o", nc_path, cdl_path]
call_kwargs = {}
else:
# No CDL file : pipe 'cdl_str' directly into the ncgen program.
Expand Down