PP field extra data words fix #5058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
requested changes
Nov 11, 2022
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Might be more to come, when I understand this properly!
lib/iris/tests/unit/fileformats/pp/test__data_bytes_to_shaped_array.py
Outdated
Show resolved
Hide resolved
…array.py Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
for more information, see https://pre-commit.ci
trexfeathers
approved these changes
Nov 14, 2022
Contributor
|
Thanks @bjlittle! A tangible improvement for those still using PP format 😊 |
Member
|
Thanks @bjlittle @trexfeathers! 😊🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR addresses an issue with MULE altered PP files that include at least 1 extra word in the field data (specified by
lblrec) as padding, causing the expected field data shape (specified bylbrowandlbnpt) to disagree with the actual payload data size.This is limited to specific diagnostics which have been reduced over
longitude.Normally, the fix would be within MULE, however there are now PP files in existence with this issue, and
irisis unable to load and save them.This PR addresses this issue for the specific use case that we are aware of; the solution has not been generalised.
Ping @rcomer
Consult Iris pull request check list