Skip to content

Conversation

@trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Nov 10, 2022

🚀 Pull Request

Description

This ensures:

  • The reader sees all the columns of the generated DataFrames.
  • Doctests pass consistently regardless of terminal settings.
    (We were getting inconsistent results between local machines and GHA).

To see the rendered version: view the Examples heading under the iris.pandas.as_data_frame() API docs here.

I recommend reviewing the code changes using Unified mode, due to the unusual width of the lines.

image


Consult Iris pull request check list

@trexfeathers
Copy link
Contributor Author

Thanks for putting me onto this fix, @hsteptoe 😊

@trexfeathers trexfeathers changed the title iris.pandas.as_data_frame doctests full width iris.pandas.as_data_frame() doctests full width Nov 10, 2022
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stephenworsley stephenworsley merged commit c1cb14c into SciTools:pandas_ndim Nov 10, 2022
@trexfeathers trexfeathers deleted the doctest_fix branch November 29, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants