Skip to content

[CI Bot] environment lockfiles auto-update #5051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjlittle merged 2 commits into from
Nov 16, 2022
Merged

[CI Bot] environment lockfiles auto-update #5051

bjlittle merged 2 commits into from
Nov 16, 2022

Conversation

@scitools-ci
Copy link
Contributor

@scitools-ci scitools-ci bot commented Nov 5, 2022

Lockfiles updated to the latest resolvable environment.

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

@scitools-ci scitools-ci bot added Bot A bot generated issue/pull-request New: Pull Request labels Nov 5, 2022
@scitools-ci scitools-ci bot force-pushed the auto-update-lockfiles branch from 21a3d28 to ed26f91 Compare November 5, 2022 00:08
@trexfeathers
Copy link
Contributor

trexfeathers commented Nov 7, 2022

Need to find out why graphviz has gone so far backwards

@trexfeathers
Copy link
Contributor

trexfeathers commented Nov 7, 2022

Need to find out why graphviz has gone so far backwards

Nothing obvious online. I just tried resolving locally and it went back to 6.0.1, so I'm going to try re-running the action...

@scitools-ci scitools-ci bot force-pushed the auto-update-lockfiles branch from ed26f91 to 138176a Compare November 7, 2022 10:51
@trexfeathers
Copy link
Contributor

trexfeathers commented Nov 7, 2022

Re-running has now spread the graphviz backstep to py39, as well as py38. I don't trust this intermittent behaviour, not sure what to do...

@scitools-ci scitools-ci bot force-pushed the auto-update-lockfiles branch from 138176a to a1de125 Compare November 12, 2022 00:08
@trexfeathers
Copy link
Contributor

trexfeathers commented Nov 16, 2022

@bjlittle suggests trying a minimum graphviz pin, even just as an experiment, as that sometimes makes the problem magically go away.

@scitools-ci scitools-ci bot force-pushed the auto-update-lockfiles branch from a1de125 to 1a60d08 Compare November 16, 2022 12:19
@bjlittle
Fix auto update lockfiles (#5070)
dc48071 
* introduce graphviz min pin

* update lock files
@bjlittle bjlittle self-requested a review November 16, 2022 16:55
bjlittle
bjlittle approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers We've now got a temporary min pin for graphviz to unify the version across our supported versions of Python. This only applies to conda and not pip.

Bit of an odd behaviour, but at least now we have consistency.

@bjlittle bjlittle merged commit f9c158c into main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjlittle bjlittle bjlittle approved these changes

Assignees

@bjlittle bjlittle

Labels

Bot A bot generated issue/pull-request New: Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trexfeathers @bjlittle @web-flow