Skip to content

Sample code to convert ORCA data into a meshcube. #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trexfeathers merged 3 commits into from
Oct 6, 2022
Merged

Sample code to convert ORCA data into a meshcube. #5013

trexfeathers merged 3 commits into from
Oct 6, 2022

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Oct 4, 2022 •
edited
Loading

Fulfils a long-ago promise to write up + share how to make meshes for ORCA data.

Test docs-build of this branch, showing : the new section

trexfeathers
trexfeathers requested changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read through yet, but the image doesn't fit with the others on the page. The other images prioritise showing the kind of grid/mesh that's being converted, even if the image is not part of the script. Could you find something illustrative of an ORCA grid, either from the Internet or using GeoVista?

@pp-mo
Copy link
Member Author

pp-mo commented Oct 5, 2022 •
edited
Loading

I haven't read through yet, but the image doesn't fit with the others on the page.

Okay, that is a good call !
I've now replaced that image with something hopefully more suitable.

N.B. now also provided a test docs-build here

trexfeathers
trexfeathers requested changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @pp-mo!

Definitely deserves a What's New entry

@trexfeathers
Copy link
Contributor

trexfeathers commented Oct 6, 2022

GHA is being weird. I'm merging anyway - the offending job passed for previous near-identical commits AND passes for other Python versions.

@trexfeathers trexfeathers merged commit 959b590 into SciTools:main Oct 6, 2022
@pp-mo
Copy link
Member Author

pp-mo commented Oct 6, 2022

Unfortunately RTD seems to not like my cross-link.
But weirdly my local Sphinx build does get it right.
So I'm experimenting with a fix ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trexfeathers trexfeathers trexfeathers approved these changes

Assignees

@trexfeathers trexfeathers

Labels

Feature: UGRID Type: Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pp-mo @trexfeathers