Skip to content

Conversation

@ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Aug 11, 2022

🚀 Iris Glossary

Description

Created a glossary of terms for iris docs, currently located within user guide. Intended to just be a quick lookup, with links to other relevant terms and also the more in depth docs documents.

Most everything at this point is susceptible to change; please feel free to suggest new terms, removal of terms, editing or (hopefully not needed) correcting of definitions, and formatting changes.

Current Build: https://esadek-mo-irisdocs.readthedocs.io/en/latest/userguide/glossary.html

@pp-mo
Copy link
Member

pp-mo commented Aug 17, 2022

Liking the idea, but there's a lot to do !
I think we need a huddle on this after v3.3 is done.

Also possible content / references : #3883 #4498

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super job @ESadek-MO! I've added some minor comments. It would also be great to see NetCDF, GRIB, PP and FF formats mentioned.

@ESadek-MO
Copy link
Contributor Author

ESadek-MO commented Sep 2, 2022

Added Table Of Contents; done manually as couldn't seem to find an appropriate automatic version. Its inclusion is up for discussion; might be unnecessary or too lengthy, and might be negated by the use of Ctrl F.

Newer definitions (each file format, xarray and coordinate factory) could perhaps do with some tinkering. Appropriate "more information" links might also need more work, currently some third party sites are used. Perhaps @pp-mo might have some insight?

There is potential to add links to the glossary from the docs, included as the docs are organically updated themselves, but for the time being the existence of the glossary should suffice.

There is also potential of examples being added to definitions, although I fear this might disrupt the brevity. A separate page of examples, linked from the glossary, could be a solution to this, but would require more work and perhaps end up too disjointed.

@ESadek-MO ESadek-MO marked this pull request as ready for review September 2, 2022 14:49
@ESadek-MO
Copy link
Contributor Author

Removed TOC, replaced with alphabetical links. Perhaps needs better formatting, and a fair amount of letters are currently unused, and as such messy.

@ESadek-MO
Copy link
Contributor Author

Hopefully final edit (excluding reviews); done away with any sort of table of contents, alphabetical or non. It just appeared to be too messy, no nice way of doing it. Older version remain in prior commits, but unless a mass vote to revert I think this is final version for the time being.

@bjlittle bjlittle assigned trexfeathers and unassigned ESadek-MO Sep 14, 2022
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good @ESadek-MO, great job! Please could you add a What's New entry and I'll merge.

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! I especially like the extensive cross-linking.

Meanwhile on my account .. A lot of fiddling changes, more- or less-important.
Not an ideal way of raising them. I'm now thinking, so if it's all too fiddly please merge the initial, and I will re-propose them in a separate PR where they could be discussed separately.

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As promised : decouple the text in term refs from the exact Glossary name

@pp-mo pp-mo self-requested a review September 28, 2022 11:38
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't finish the job + it makes a bit of a mess.
Hopefully these suggestions make it complete (but you should see on build)

…f small changes, so going to have to go through and test I haven't broken anything
…about units definition, but not an urgent change
@ESadek-MO
Copy link
Contributor Author

ESadek-MO commented Sep 28, 2022

Hopefully ready for approval.
I did notice the "Unit" definition uses itself within the definition: (a unit is a unit of measurement...). I think that's okay, as I can't think of a definition without overcomplicating matters, but something to keep in mind perhaps.

@trexfeathers
Copy link
Contributor

Over to you, @pp-mo

@pp-mo pp-mo merged commit 96c00b6 into SciTools:main Sep 28, 2022
@pp-mo
Copy link
Member

pp-mo commented Sep 28, 2022

Many Thanks @ESadek-MO and sorry for repeated change requests !

@ESadek-MO
Copy link
Contributor Author

Possible Additions in future:
Interpolation,
(Within Cubes) -
cell-measures
ancillary variables

Other things we might consider in the glossary
Mesh
Coordinate System

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants