Skip to content

Fix stock CDL headers for unlimited time dimension. #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pp-mo merged 3 commits into from
Jun 23, 2022
Merged

Fix stock CDL headers for unlimited time dimension. #4827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80d5837
Fix CDL headers for tests.stock.netcdf.
trexfeathers Jun 23, 2022
e84d7fb
Whats new entry.
trexfeathers Jun 23, 2022
7cd154c
Improved unlimited dimension check in stock NetCDF generation.
trexfeathers Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/src/whatsnew/latest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,11 @@ This document explains the changes made to Iris for this release
bin in the system PATH.
(:pull:`4794`)

#. `@trexfeathers`_ and `@pp-mo`_ fixed the CDL headers for
:mod:`iris.tests.stock.netcdf` to allow generation of NetCDF-4 files with an
unlimited time dimension.
(:pull:`4827`)


.. comment
Whatsnew author names (@github name) in alphabetical order. Note that,
Expand Down
4 changes: 4 additions & 0 deletions lib/iris/tests/stock/file_headers/xios_2D_face_half_levels.cdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,8 @@ variables:
:name = "${DATASET_NAME}" ;
// original name = "lfric_ngvat_2D_1t_face_half_levels_main_conv_rain"
:Conventions = "UGRID" ;

// data
data:
time_instant = 0 ;
}
4 changes: 4 additions & 0 deletions lib/iris/tests/stock/file_headers/xios_3D_face_full_levels.cdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,8 @@ variables:
:name = "${DATASET_NAME}" ;
// original name = "lfric_ngvat_3D_1t_full_level_face_grid_main_u3"
:Conventions = "UGRID" ;

// data
data:
time_instant = 0 ;
}
4 changes: 4 additions & 0 deletions lib/iris/tests/stock/file_headers/xios_3D_face_half_levels.cdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,8 @@ variables:
:name = "${DATASET_NAME}" ;
// original name = "lfric_ngvat_3D_1t_half_level_face_grid_derived_theta_in_w3"
:Conventions = "UGRID" ;

// data
data:
time_instant = 0 ;
}
2 changes: 1 addition & 1 deletion lib/iris/tests/stock/netcdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def _add_standard_data(nc_path, unlimited_dim_size=0):
ds = netCDF4.Dataset(nc_path, "r+")

unlimited_dim_names = [
dim for dim in ds.dimensions if ds.dimensions[dim].size == 0
dim for dim in ds.dimensions if ds.dimensions[dim].isunlimited()
]
# Data addition dependent on this assumption:
assert len(unlimited_dim_names) < 2
Expand Down