address np printoptions pre/post v1.22 #4486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Closed
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
I have confirmed for myself that this will fix the #4480 failures, and I think I understand what's going on! I just had one comment about avoiding a private import.
This was referenced Jan 11, 2022
pp-mo
approved these changes
Jan 11, 2022
Member
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
Good enough for now, as noted in comments.
Member
Author
|
Thanks @pp-mo and @trexfeathers 🍻 🥳 💯 There was a lot of history and tech debt associated with this one. Hopefully it's raised the priority on us committing to resolving #3048 and moving away from what we have at the moment 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR addresses the test failures within #4480 when updating to the latest
numpyv1.22.0.We've now dropped support within
irisforpy37(#4481) but we still require to supportnumpy>= v1.19 (NEP29 Support Table). However numpy/numpy#19686 introduced a change that impactsiris.util.format_arraydue to our use of the internalnumpy.core.arrayprint._formatArrayfunction.This PR maintains our continuing
numpyv1.13 legacy array printing format forpy38andnumpy>= 1.19.As a separate concern, it would be wise to commit to addressing #3048, by at least bumping to the more recent
numpyv1.21 legacy array printing.Consult Iris pull request check list