Update pp_save_rules.py #4391
Update pp_save_rules.py #4391
Conversation
Make sure call to cftime.datetime has the requisite number of arguments, in this case ensuring the start date is December 1st of the year the start date is actually in, when the month is december.
|
Hi @pdearnshaw, thanks for your contribution! It looks like you have branched from an old revision of |
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks @pdearnshaw! You deserve to give yourself a mention in the latest What's New page.
|
I have created pull request #4404 that adds a line to bugs fixed section of the release notes as requested. Not sure if this was the ideal way of doing this, but I do not know any better!! |
This could have gone in this same PR, but we can work with you separate PR too! |
* main: (23 commits) Suggest type hinting (SciTools#4390) area weight regrid test fixes (SciTools#4432) Update latest.rst (SciTools#4425) Added @wjbenfold to the core dev list (SciTools#4423) Removed addition of period from wrap_lons. (SciTools#4421) Add release docs sections describing the role of a Release Manager (SciTools#4413) Subset should always return None if no value matches are found (SciTools#4417) What's new for SciTools#4400 (SciTools#4422) `iris.analysis.AreaWeighted` regrid speedup (SciTools#4400) [pre-commit.ci] pre-commit autoupdate (SciTools#4419) Remove newline to satisfy setuptools (SciTools#4418) Updated environment lockfiles (SciTools#4416) NAME loader fixes (SciTools#4411) Updated whatsnew for PR 4402 (SciTools#4410) Support test data in benchmark workflows (SciTools#4402) What's new for pr 4387 (SciTools#4405) Make concat mismatch warning for scalar coords more accurate (SciTools#4387) Added line to latest release notes for updates to pp_save_rules.py (SciTools#4404) Update pp_save_rules.py (SciTools#4391) [pre-commit.ci] pre-commit autoupdate (SciTools#4403) ...
3 participants
Make sure call to cftime.datetime has the requisite number of arguments, in this case ensuring the start date is December 1st of the year the start date is actually in, when the month is december.
🚀 Pull Request
Description
If trying to save a climatological mean for DJF to PP, when the start of period is in december, there is a failure as there is a call to cftime.datetime with only 1 argument. This breaks the call to cftime.datetime as this requires at least 3 arguments. The change in this request adds the remaining required arguments in a consistent manner with the existing code.
Consult Iris pull request check list