Skip to content

Prevent warning in test_Saver #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trexfeathers merged 3 commits into from
Oct 15, 2021
Merged

Prevent warning in test_Saver #4376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18c8ca3
mock the default_fillvals
rcomer Oct 14, 2021
ef6f74f
whatsnew
rcomer Oct 14, 2021
cee6def
comment
rcomer Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/src/whatsnew/latest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@ This document explains the changes made to Iris for this release
#. `@bjlittle`_ enabled the `sort-all`_ `pre-commit`_ hook to automatically
sort ``__all__`` entries into alphabetical order. (:pull:`4353`)

#. `@rcomer`_ modified a NetCDF saver test to prevent it triggering a numpy
deprecation warning. (:issue:`4374`, :pull:`4376`)

.. comment
Whatsnew author names (@github name) in alphabetical order. Note that,
core dev names are automatically included by the common_links.inc:
Expand Down
3 changes: 3 additions & 0 deletions lib/iris/tests/unit/fileformats/netcdf/test_Saver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
# importing anything else.
import iris.tests as tests # isort:skip

import collections
from contextlib import contextmanager
from unittest import mock

Expand Down Expand Up @@ -186,6 +187,8 @@ def test_big_endian(self):
def test_zlib(self):
cube = self._simple_cube(">f4")
api = self.patch("iris.fileformats.netcdf.netCDF4")
# Define mocked default fill values to prevent deprecation warning (#4374).
api.default_fillvals = collections.defaultdict(lambda: -99.0)
with Saver("/dummy/path", "NETCDF4") as saver:
saver.write(cube, zlib=True)
dataset = api.Dataset.return_value
Expand Down