Skip to content

Remove Cartopy 0.19 workaround #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trexfeathers merged 2 commits into from
Oct 1, 2021
Merged

Remove Cartopy 0.19 workaround #4349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd54e61
remove workaround
rcomer Sep 30, 2021
2fe80f9
whatsnew
rcomer Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/src/whatsnew/latest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ This document explains the changes made to Iris for this release
#. `@rcomer`_ modified the ``animation`` test to prevent it throwing a warning
that sometimes interferes with unrelated tests. (:pull:`4330`)

#. `@rcomer`_ removed a now redundant workaround in :func:`~iris.plot.contourf`.
(:pull:`4349`)


.. comment
Whatsnew author names (@github name) in alphabetical order. Note that,
Expand Down
11 changes: 0 additions & 11 deletions lib/iris/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,17 +1089,6 @@ def contourf(cube, *args, **kwargs):
zorder = result.collections[0].zorder - 0.1
axes = kwargs.get("axes", None)

# Workaround for cartopy#1780. We do not want contour to shrink
# extent.
if axes is None:
_axes = plt.gca()
else:
_axes = axes

# Subsequent calls to dataLim.update_from_data_xy should not ignore
# current extent.
_axes.dataLim.ignore(False)

contour(
cube,
levels=levels,
Expand Down