Skip to content

Ugrid save mesh #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjlittle merged 3 commits into from
Sep 29, 2021
Merged

Ugrid save mesh #4339

bjlittle merged 3 commits into from
Sep 29, 2021

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Sep 24, 2021 •
edited
Loading

🚀 Pull Request

Description

Mesh saving.
An addon to the general unstructured-cube saving (#4318).

This does further complicate things a bit, hopefully not too much.

Consult Iris pull request check list

@pp-mo pp-mo marked this pull request as draft September 24, 2021 11:41
@pp-mo pp-mo force-pushed the ugrid_save_mesh branch 2 times, most recently from 949119b to 0b49f71 Compare September 28, 2021 14:03
@bjlittle bjlittle self-requested a review September 28, 2021 14:45
@bjlittle bjlittle self-assigned this Sep 28, 2021
@pp-mo pp-mo marked this pull request as ready for review September 28, 2021 14:54
pp-mo
pp-mo commented Sep 28, 2021
View reviewed changes
bjlittle
bjlittle requested changes Sep 29, 2021
View reviewed changes
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pp-mo This is lovely... slots in quite neatly to easily extend the capability.

Minor suggestion on the save_mesh API location to service, so consider that, otherwise we're good to go 🍻

@bjlittle
Copy link
Member

bjlittle commented Sep 29, 2021

@pp-mo Could you also add a whatsnew entry for this PR, and also #4318 ?

@pp-mo
Copy link
Member Author

pp-mo commented Sep 29, 2021

a whatsnew entry for this PR, and also #4318

Whoops yes, absolutely.
I'll add them both in this PR, I guess that is good enough.

pp-mo
pp-mo commented Sep 29, 2021
View reviewed changes
@pp-mo
Copy link
Member Author

pp-mo commented Sep 29, 2021

Thanks @bjlittle !

Now addressed above comments (I hope).
Please re-consider.. 🙏

bjlittle
bjlittle reviewed Sep 29, 2021
View reviewed changes
bjlittle
bjlittle reviewed Sep 29, 2021
View reviewed changes
@bjlittle bjlittle merged commit 2dc22e4 into SciTools:main Sep 29, 2021
@pp-mo pp-mo deleted the ugrid_save_mesh branch March 18, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjlittle bjlittle bjlittle approved these changes

Assignees

@bjlittle bjlittle

Labels

Feature: UGRID Type: Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pp-mo @bjlittle