Pre ugridsave refactor #4297
Closed
Pre ugridsave refactor #4297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
force-pushed
the
pre_ugridsave_refactor
branch
from
9e770f7 to
42085d7
Compare
pp-mo
force-pushed
the
pre_ugridsave_refactor
branch
from
d5fcbd8 to
504fb11
Compare
pp-mo
commented
Aug 31, 2021
| # This gives consistent CDL across different platforms. | ||
| def sort_key(line): | ||
| return ("UNLIMITED" not in line, line) | ||
| if "dimensions:" in lines: |
Member
Author
There was a problem hiding this comment.
Interesting fix, maybe useful to adopt generally :
Without it, assertCDL fails on a saved scalar cube (i.e. which has no dims)
Member
Author
|
Replaced by #4301 (which is non-draft) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Refactoring netcdf variable creation routines.
Now squashed down to 2 commits :
Consult Iris pull request check list