Straw Man: make collapsed points configurable #4295
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Previously, @duncanwp proposed changing the behaviour of
coord.collapsedto use a mean rather than the current behaviour of taking the mid-point between the newly calculated bounds (#3029). This would have been a breaking change and, I think, there may be cases where the mean isn't the best choice.What if we made the treatment of points a user choice?
Make a cube
Default behaviour is unchanged
But maybe we decide that the mean would be a better choice for 'bar'
In applications that calculate climatologies (#4098), neither the mid-point nor the mean really work, because averaging Januarys can give us July:
But we could reasonably use a max or min to get a sensible time of year
Obviously it would need a lot more work to do this properly, including addressing
aggregated_by.Consult Iris pull request check list