move .flake8 to setup.cfg#4200
Merged
trexfeathers merged 1 commit intoSciTools:masterfrom Jun 17, 2021
Merged
Conversation
bjlittle
force-pushed
the
move-flake8-config-to-setup
branch
from
3a96c07 to
9d84c5a
Compare
trexfeathers
approved these changes
Jun 17, 2021
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
The flake8 CI run was successful, and I can confirm that you've transferred the .flake8 contents verbatim. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR consolidates the
.flake8configuration intosetup.cfgi.e., one less configuration file in the root directory 🥳Consult Iris pull request check list