mesh-data-model dev version + purge plotting#4114
Merged
pp-mo merged 2 commits intoSciTools:mesh-data-modelfrom May 4, 2021
Merged
mesh-data-model dev version + purge plotting#4114pp-mo merged 2 commits intoSciTools:mesh-data-modelfrom
pp-mo merged 2 commits intoSciTools:mesh-data-modelfrom
Conversation
bjlittle
added
Feature: UGRID
New: Pull Request
Type: Feature Branch
pp-mo
approved these changes
May 4, 2021
Member
There was a problem hiding this comment.
This all looks pretty clean + sensible.
The only thing I can find amiss is that there is still a mention of experimental.irsi.ugrid.plot in the file docs/src/sphinxext/generate_package_rst.py, which I think should have got "pruned out".
I don't that can do any actual harm, though ?
Fix if you fancy, or merge at will !
Member
Author
|
@pp-mo Yup, thanks 👍 Forgot to remove that piece of connective tissue. I'll push that change, then we'll be good to go. Nice one |
Member
Author
|
Merging with CI test failures is fine atm |
Member
|
The outstanding test failures should resolve when we fix other problems |
Member
Author
|
Awesome, thanks @pp-mo 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR backs out
iris.experimental.ugrid.plotand bumps themesh-data-modelfeature branch version back to3.1.dev0after the3.1a0engineering tag.This unblocks the
mesh-data-modelfeature branch and allows it to be merged tomaster.Consult Iris pull request check list