Skip to content

Topology tolerance [AVD-1723] #4099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trexfeathers merged 6 commits into from
Apr 21, 2021
Merged

Topology tolerance [AVD-1723] #4099

trexfeathers merged 6 commits into from
Apr 21, 2021

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Apr 15, 2021 •
edited
Loading

🚀 Pull Request

Description

Allow "wrong" topology-dimension on a UGRID mesh, deduce "correct" value from attached connectivites.

This is just one of the pending "tolerant loading" ideas which we listed elsewhere (AVD-1723).
But this one will help with the forthcoming internal release demo.

Consult Iris pull request check list

@pp-mo pp-mo changed the base branch from master to mesh-data-model April 15, 2021 11:58
@pp-mo pp-mo force-pushed the toplogy_tolerant branch from 9d60eae to e463aed Compare April 15, 2021 15:48
@pp-mo pp-mo changed the title Toplogy tolerant [AVD-1723] Topology tolerance [AVD-1723] Apr 15, 2021
@pp-mo pp-mo marked this pull request as ready for review April 15, 2021 15:54
@pp-mo pp-mo requested a review from stephenworsley April 15, 2021 15:54
stephenworsley
stephenworsley requested changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments to address.

@pp-mo
Copy link
Member Author

pp-mo commented Apr 19, 2021 •
edited
Loading

Thanks @stephenworsley
I hope the latest commit addresses your suggestions
Please re-review !

N.B. I'm not sure if the broken docs links are transient : I have re-spun a couple of times and they seem to consistently fail.
Depending on the current state of the target branch, we can either consider merging this without fixing that, or perhaps we will need a separate fix on the target branch.
I am currently re-running this test on the latest mesh-data-model branch commit : That succeeded ~1 week ago when merged, but I suspect will fail now...

trexfeathers
trexfeathers reviewed Apr 19, 2021
View reviewed changes
stephenworsley
stephenworsley approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this is good to merge.

@pp-mo pp-mo mentioned this pull request Apr 20, 2021
Closed
@pp-mo pp-mo marked this pull request as draft April 20, 2021 15:58
@pp-mo pp-mo marked this pull request as ready for review April 20, 2021 17:55
@pp-mo
Copy link
Member Author

pp-mo commented Apr 20, 2021

Back, with requested changes to warnings/logging.

@trexfeathers and/or @stephenworsley : Please re-review !

@pp-mo
Copy link
Member Author

pp-mo commented Apr 20, 2021

Thanks @trexfeathers for pointing out the existing functionality for logging tests.
I was very close to committing effort to writing that myself !

trexfeathers
trexfeathers requested changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pp-mo! Couple of little things to address.

@pp-mo
Copy link
Member Author

pp-mo commented Apr 21, 2021 •
edited
Loading

Thanks for suggestion. Done that, I hope ?
BTW I also moved the support vars for the synthetic data calls into the inside of the logging context block, which I think reads better.

Please re-review @trexfeathers

@trexfeathers
Copy link
Contributor

trexfeathers commented Apr 21, 2021

Merging despite the link check failures. Once #4104 is in, we'll do a merge-back to get that fix into mesh-data-model.

@trexfeathers trexfeathers merged commit 1ed885e into SciTools:mesh-data-model Apr 21, 2021
@pp-mo
Copy link
Member Author

pp-mo commented Apr 21, 2021

Many thanks, significantly better for your suggestions @stephenworsley @trexfeathers !
💐

@pp-mo pp-mo deleted the toplogy_tolerant branch April 21, 2021 13:40
@pp-mo pp-mo mentioned this pull request Apr 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trexfeathers trexfeathers trexfeathers approved these changes

@stephenworsley stephenworsley stephenworsley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pp-mo @trexfeathers @stephenworsley