Meshcoord printout [AVD-1592]#4054
Merged
bjlittle merged 3 commits intoSciTools:mesh-data-modelfrom Mar 9, 2021
Merged
Conversation
Member
@pp-mo Point taken. To be honest we should rationalise and align all our |
f5ebab1 to
62e4399
Compare
Member
Author
|
Rebased onto #4053 (effectively). In the meantime, attending to the existing comments above (though now outdated). |
Member
Author
|
I think that's it for the outstanding review issues. |
62e4399 to
1568a8a
Compare
Member
Author
|
Rebased again ( 😓 ) |
eb44556 to
6d2b121
Compare
bjlittle
approved these changes
Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Added string representations for MeshCoord
Waiting until #4053 is in : Which this is based on.
(so it won't merge into the target branch, as yet)
I have made the str/repr versions slightly different, following discussion with @bjlittle
I'm still a little uncertain that the results are the most useful, though:
<Mesh object at 0x{address}>,Mesh('name')Consult Iris pull request check list