cirrus-ci add python version to lint task fingerprint#4047
Merged
jamesp merged 1 commit intoSciTools:masterfrom Mar 3, 2021
Merged
cirrus-ci add python version to lint task fingerprint#4047jamesp merged 1 commit intoSciTools:masterfrom
jamesp merged 1 commit intoSciTools:masterfrom
Conversation
bjlittle
commented
Mar 2, 2021
| folder: ~/.cache/pip | ||
| fingerprint_script: | ||
| - echo "${CIRRUS_TASK_NAME}" | ||
| - echo "${CIRRUS_TASK_NAME} py${PYTHON_VERSION}" |
Member
Author
There was a problem hiding this comment.
Add the container base PYTHON_VERSION to the pip_cache fingerprint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR adds the
PYTHON_VERSIONto the fingerprint of thepip_cacheof thelint_taskforcirrus-ci. This will be required to discriminate whenever the base Python version of the container changes, and thus should result in invalidating thepip_cache.This PR also fully qualifies the use of environment variables and normalises the use of strings.
Consult Iris pull request check list