add mesh __str__ and __repr__ support#4033
Merged
trexfeathers merged 1 commit intoSciTools:mesh-data-modelfrom Feb 25, 2021
Merged
add mesh __str__ and __repr__ support#4033trexfeathers merged 1 commit intoSciTools:mesh-data-modelfrom
trexfeathers merged 1 commit intoSciTools:mesh-data-modelfrom
Conversation
bjlittle
added
Type: Enhancement
Feature: UGRID
New: Pull Request
Type: Feature Branch
bjlittle
commented
Feb 24, 2021
bjlittle
commented
Feb 24, 2021
bjlittle
commented
Feb 24, 2021
bjlittle
force-pushed
the
mesh-str-repr-support
branch
from
e07ddae to
7a747b4
Compare
bjlittle
commented
Feb 24, 2021
trexfeathers
approved these changes
Feb 25, 2021
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Nicely thought out @bjlittle ; I agree with your decisions, and everything behaves as expected under testing 💐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR adds
__str__and__repr__support for theMeshet al.Note that, for the managers and
ConnectivityI've opted to make the__repr__unambiguous, whereas the__str__is a slicker summary of content.For the
Mesh, which is metadata and data rich, I've not made this distinction i.e., only implementedMesh.__repr__, hencestr(mesh)will return the same result asrepr(mesh).Consult Iris pull request check list