Skip to content

add minimalist mesh __eq__ support #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trexfeathers merged 1 commit into from
Feb 23, 2021
Merged

add minimalist mesh __eq__ support #4028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions lib/iris/experimental/ugrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,8 +917,8 @@ def normalise(location, axis):
raise NotImplementedError(emsg)

def __eq__(self, other):
# TBD
return NotImplemented
# TBD: this is a minimalist implementation and requires to be revisited
return id(self) == id(other)

def __getstate__(self):
return (
Expand All @@ -928,8 +928,10 @@ def __getstate__(self):
)

def __ne__(self, other):
# TBD
return NotImplemented
result = self.__eq__(other)
if result is not NotImplemented:
result = not result
return result

def __repr__(self):
# TBD
Expand Down Expand Up @@ -1304,8 +1306,8 @@ def __init__(self, node_x, node_y, edge_x=None, edge_y=None):
self.edge_y = edge_y

def __eq__(self, other):
# TBD
return NotImplemented
# TBD: this is a minimalist implementation and requires to be revisited
return id(self) == id(other)

def __getstate__(self):
return self._members
Expand All @@ -1315,8 +1317,10 @@ def __iter__(self):
yield item

def __ne__(self, other):
# TBD
return NotImplemented
result = self.__eq__(other)
if result is not NotImplemented:
result = not result
return result

def __repr__(self):
args = [
Expand Down Expand Up @@ -1706,8 +1710,8 @@ def __init__(self, *connectivities):
self.add(*connectivities)

def __eq__(self, other):
# TBD
return NotImplemented
# TBD: this is a minimalist implementation and requires to be revisited
return id(self) == id(other)

def __getstate__(self):
return self._members
Expand All @@ -1717,8 +1721,10 @@ def __iter__(self):
yield item

def __ne__(self, other):
# TBD
return NotImplemented
result = self.__eq__(other)
if result is not NotImplemented:
result = not result
return result

def __repr__(self):
args = [
Expand Down