pin cftime<1.3.0 #3927
Merged
pin cftime<1.3.0 #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
See errors investigation : #3923 |
Contributor
|
Given the long wait times for Travis at the moment, the simplicity of this change, and @rcomer 's observation in #3923 (comment), I'm going to merge this without waiting for Travis 😬 |
trexfeathers
approved these changes
Nov 23, 2020
Member
Author
|
I've got a pull request migrating Travis-CI to Cirrus-CI waiting in the wings... might have to prioritise some effort on that now as Travis-CI is simply unusable as it stands. |
Contributor
|
What's the easiest way for this commit to also be merged into the v3.0.x branch, as the tests are currently failing there for the same reason? |
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR pins
cftime<1.3.0. Theiristests are broken with the latest released version1.3.0, which pulls from PyPI.Pinning will give us time to investigate and either fix
irisand/or feedback to thecftimedevelopers.Consult Iris pull request check list