Allow cube-adjust to return a new cube. #3915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
approved these changes
Oct 26, 2020
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Makes sense, LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned : SciTools-incubator/iris-ugrid#24 (comment)
I think this is desirable, to enable iris-ugrid to represent unstructured data with a new derived class
Ucube(Cube).By allowing the post-modify action to return a new object, the iris-ugrid loader can replace Cube-s with Ucube-s, instead of patching a cube instance.
Apart from being cleaner, I think it will eventually prove essential for unstructured cubes to belong to a specialised subclass of
Cube, so that we can use inheritance and overriding to efficiently extend features.See for example #3914, which assumes we will use a
Ucube(Cube)class to extend cube.summary().