Skip to content

Conversation

@abooton
Copy link
Contributor

@abooton abooton commented Dec 9, 2019

Ensure that an x_dim and y_dim exist, and are ordered as [..., y_dim, x_dim]. Cleans up function.
Is in preparation for optimising averaging.

@abooton abooton changed the title Area weighted regrid: enforce xdim ydim _regrid_area_weighted_array:: enforce xdim ydim Dec 9, 2019
@abooton abooton mentioned this pull request Dec 9, 2019
12 tasks
Copy link
Contributor

@ehogan ehogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the comments on #3587 also apply here, so I'll wait for #3587 until commenting further :)

if not src_masked and not new_data.mask.any():
new_data = new_data.data

# Restore axis to original order
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore data to original form?

@abooton abooton force-pushed the tweak_area_weighting_regrid_enforce_xdim_ydim branch from 1afae14 to 7d99492 Compare December 12, 2019 08:49
@abooton
Copy link
Contributor Author

abooton commented Dec 12, 2019

Closed. Superseded by #3595

@abooton abooton closed this Dec 12, 2019
@abooton abooton changed the title _regrid_area_weighted_array:: enforce xdim ydim PI-2472: _regrid_area_weighted_array:: enforce xdim ydim Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants