Generic 'cube_dims' function for all _DimensionMetadata objects. #3551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@stephenworsley I believe we were discussing that this might contribute to #3546, |
stephenworsley
requested changes
Nov 19, 2019
Contributor
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Looks like this needs black reformatting, once that's done this should be good to go.
Member
Author
|
Thanks @stephenworsley |
Member
Author
|
Also rebased #3550 onto this, as it helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this is to enable writing code that handles _DimensionalMetadata objects in a generic way.
For example, it will avoid the need for the extra method keyword here.