Skip to content

Conversation

@bjlittle
Copy link
Member

This PR is a follow-up to #3468, and adds a whatsnew entry highlighting that our matplotlib dependency is now unpinned.

Copy link
Contributor

@abooton abooton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you don't need the second "now" in the last sentence, but it is fine really.
I assume line length isn't a problem here.

@bjlittle
Copy link
Member Author

bjlittle commented Nov 13, 2019

@abooton Nice spot 👀 ... now I've now removed the superfluous "now".

Good question... line length doesn't matter here for the whatsnew contributions. The whatsnew aggregation process takes care of line concatenation for each entry 👍

@abooton abooton merged commit 6439fe2 into SciTools:master Nov 15, 2019
@bjlittle
Copy link
Member Author

@abooton Thanks 🎉

@bjlittle bjlittle deleted the whatsnew-unpin-mpl branch November 15, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants