Straw man: alternative solution for non-cubes in cubelists #3510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised at #1897 , it is possible for cubelists to contain objects that are not cubes. This can lead to operations on cubelists failing with
AttributeErrors that can be confusing for the user. #3238 attempted to lock down the cubelist contents so only cubes are allowed. That solution turned out to involve a seemingly disproportionate amount of new code, and also prompted objections that cube-like "duck type" objects should be accommodated.Within #3238, @pp-mo suggested
This new branch introduces a decorator to catch
AttributeErrors and instead raise a more helpful error about the cubelist contents being wrong.Advantage I believe this should solve the question of duck types, as anything that used to work still will.
Disadvantages
AttributeErrors might occur because of some other problem than the cubelist contents. Easiest solution to this is to make the eventual error message more detailed: "This error was triggered: '...' The most likely explanation for an AttributeError here is..."Disclaimers