Skip to content

Update copyright years in license headers #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corinnebosley merged 2 commits into from
May 30, 2019
Merged

Update copyright years in license headers #3318

corinnebosley merged 2 commits into from
May 30, 2019

Conversation

@lbdreyer
Copy link
Member

@lbdreyer lbdreyer commented May 29, 2019

The license header check doesn't run in this branch so we missed a few copyright years that need updating.

This is needed so before we can do the mergeback of this branch (see #3316 )

@lbdreyer lbdreyer requested a review from corinnebosley May 29, 2019 16:19
@QuLogic
Copy link
Member

QuLogic commented May 30, 2019 •
edited
Loading

License check is skipped because this branch is missing the setting of IRIS_REPO_DIR, which is there on master.

If you re-add that, it should run here.

corinnebosley
corinnebosley approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@corinnebosley corinnebosley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Waiting for Travis confirmation, but effectively I'm happy with this.

@lbdreyer lbdreyer force-pushed the fix_license_headers branch from 6af857b to 81ce9aa Compare May 30, 2019 10:45
@corinnebosley
Copy link
Member

corinnebosley commented May 30, 2019

@lbdreyer What's the strategy here? Are we bothered that some of the license headers are still wrong? Surely the main thing here is that the checks are working.

What do you want to do?

@lbdreyer
Copy link
Member Author

lbdreyer commented May 30, 2019 •
edited
Loading

License check is skipped because this branch is missing the setting of IRIS_REPO_DIR, which is there on master.

If you re-add that, it should run here.

Thank you @QuLogic! I have cherry-picked the commit that made that change to this PR.

We will just need to skip that commit when we do the mergeback onto master!

@lbdreyer What's the strategy here? Are we bothered that some of the license headers are still wrong? Surely the main thing here is that the checks are working.

What do you want to do?

I'm going to update the license headers that the license header check is complaing about so that this won't be an issue to further PRs to this branch.
I'll fix this shortly!

@pp-mo @lbdreyer
Get licence header test working again. Cherrypicked from (SciTools#3272…
a8ee456 
…) and

modified. SKIP this commit during the mergeback.

* Fix testing cwd for licence header test to work properly.

* Remove redundant test runner --coding-tests key.

* Update all the missed header years.
@lbdreyer lbdreyer force-pushed the fix_license_headers branch from 81ce9aa to a8ee456 Compare May 30, 2019 14:51
@corinnebosley corinnebosley merged commit 710898b into SciTools:v2.2.x May 30, 2019
@corinnebosley
Copy link
Member

corinnebosley commented May 30, 2019

Thanks @lbdreyer!

@lbdreyer lbdreyer deleted the fix_license_headers branch September 3, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corinnebosley corinnebosley corinnebosley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lbdreyer @QuLogic @corinnebosley @pp-mo