Imagehash listfile for fixbranch #3311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge; clarify comments.
Member
Author
|
I think this is ready to go now. |
Member
|
I am going to respin the tests now that #3310 is merged |
lbdreyer
reviewed
May 10, 2019
lib/iris/tests/test_image_json.py
Outdated
| '/gh-pages/v4_files_listing.txt') | ||
| req = requests.get(listingfile_uri) | ||
| if req.status_code != 200: | ||
| raise ValueError('Get failed on image listings file: {}'.format( |
Member
There was a problem hiding this comment.
You could capitalise GET to make it clear it is a http request. Otherwise, the error reads a bit funnily out of context
Member
Author
There was a problem hiding this comment.
Good idea, I see what you mean 😁
Member
|
Thanks for all your work on this @pp-mo! It will be great to get this test running! |
Merged
lbdreyer
pushed a commit
to lbdreyer/iris
that referenced
this pull request
May 28, 2019
* Test-imagehash uris checked against listing file instead of github api listing. * Licence header fix. * Remove redundant import + skip; fix bytes decode; improve error message; clarify comments. * Improved error message.
lbdreyer
pushed a commit
to lbdreyer/iris
that referenced
this pull request
Jun 3, 2019
* Test-imagehash uris checked against listing file instead of github api listing. * Licence header fix. * Remove redundant import + skip; fix bytes decode; improve error message; clarify comments. * Improved error message.
lbdreyer
pushed a commit
to lbdreyer/iris
that referenced
this pull request
Jun 3, 2019
* Test-imagehash uris checked against listing file instead of github api listing. * Licence header fix. * Remove redundant import + skip; fix bytes decode; improve error message; clarify comments. * Improved error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An almost complete rewrite of
iris.tests.test_image-json.Instead of using the GitHub API to interrogate the test-iris-imagehash repo, we now just fetch an 'image listings file' which is basically the text of an
ls *.png.This is because the (unauthenticated) GitHub API access was proving very unreliable.
Note : relies on SciTools/test-iris-imagehash#23 , but that is already merged.