Skip to content

Conversation

@tv3141
Copy link
Contributor

@tv3141 tv3141 commented Nov 9, 2018

For testing with Travis we install Python using miniconda and only use this version of Python. Specifying - python: 3.6 in .travis.yml sets the version of Python that comes installed in the Travis container.

Instead:

  • use minimal travis container
  • specify Python version as env var

@tv3141 tv3141 mentioned this pull request Nov 9, 2018
2 tasks
@bjlittle
Copy link
Member

bjlittle commented Nov 11, 2018

@tv3141 Nice, I like it 👍

I'd hope that minimal containers spin up faster as well 😉

.travis.yml Outdated
- PYTHON_VERSION=3.6 TEST_TARGET=default
- PYTHON_VERSION=2.7 TEST_TARGET=example
- PYTHON_VERSION=3.6 TEST_TARGET=example
- PYTHON_VERSION=3.6 TEST_TARGET=doctest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame we have to crank the matrix permutations by hand...

@bjlittle bjlittle self-assigned this Nov 11, 2018
@bjlittle
Copy link
Member

@tv3141 Can we close this PR in preference for #3222?

@tv3141 tv3141 force-pushed the travis_python_version branch from 205d75e to eb62f4f Compare November 11, 2018 20:01
@tv3141 tv3141 force-pushed the travis_python_version branch from eb62f4f to 1a671cd Compare November 11, 2018 20:05
@tv3141
Copy link
Contributor Author

tv3141 commented Nov 11, 2018

@tv3141 Nice, I like it

I'd hope that minimal containers spin up faster as well

@bjlittle I thought so as well, but run times vary wildly. The main benefit is that CI won't rely on something in the linux image that is not used. Adding Python3.7 to the linux image caused some problems travis-ci/travis-ci#9069

@tv3141
Copy link
Contributor Author

tv3141 commented Nov 11, 2018

Close in preference of #3222

@tv3141 tv3141 closed this Nov 11, 2018
@bjlittle
Copy link
Member

@tv3141 Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants