WIP: Unpin the numpy version in our CI testing. #3024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@pelson I'm at the point where I've pretty much nailed all of failing tests by unpinning numpy in #3019, albeit indirectly through unpinning mpl. I think that I'm now going to repin mpl and force unpin numpy (as per this PR), which should allow me to bank all of the changes in that PR just for numpy. Then I'll move onto a nice, new clean PR to address mpl separately. |
Member
Author
|
Great. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently bound to an old numpy because we are pinned to an old matplotlib. @bjlittle is unpicking the matplotlib side of things, which seems to be bleeding into a numpy pinning issue. This is a WIP PR to unpin numpy separately from mpl, so that we can bank some of the great stuff that @bjlittle has been doing.