Change FUTURE flag netcdf_promote behaviour #2848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Genuine doctest issues (plus noise from TimeoutExceptions). Would you mind adding a commit that addresses the doctests? Reviewed at f1d5479 |
Member
Author
|
Thanks @pelson – my latest commit should address the doctest changes at last 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Iris v2.0, "the future has arrived". This PR swaps the behaviour of the FUTURE flag
netcdf_promoteso that the future behaviour is on by default. As the old behaviour is deprecated I've also removed the old behaviour, andFuturewill now raise an error if a user tries to set thenetcdf_promoteflag (to eitherTrueorFalse). Tests and docs are updated and I've added a whatsnew entry as well.Fixes #2845.