Skip to content

Whats New for sample data dir [ci skip] #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DPeterK merged 2 commits into from
Oct 19, 2017
Merged

Whats New for sample data dir [ci skip] #2828

DPeterK merged 2 commits into from
Oct 19, 2017

Conversation

@corinnebosley
Copy link
Member

@corinnebosley corinnebosley commented Oct 19, 2017

Covers #2787.

@corinnebosley corinnebosley requested a review from DPeterK October 19, 2017 07:55
DPeterK
DPeterK requested changes Oct 19, 2017
View reviewed changes
Copy link
Member

@DPeterK DPeterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is really small, honest...

.../src/whatsnew/contributions_v2.0.0/incompatiblechange_2017-Oct-19_remove-sample-data-dir.txt Outdated
@@ -0,0 +1 @@
* The deprecated configuration variable ```SAMPLE_DATA_DIR``` has been removed in favour of user installation of the ```iris_sample_data``` package. No newline at end of file
Copy link
Member

@DPeterK DPeterK Oct 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corinnebosley where has SAMPLE_DATA_DIR been removed from? That is, could you add a reference to iris.config in here please?

Otherwise, this whatsnew entry is great 👍

djkirkham
djkirkham reviewed Oct 19, 2017
View reviewed changes
.../src/whatsnew/contributions_v2.0.0/incompatiblechange_2017-Oct-19_remove-sample-data-dir.txt Outdated
@@ -0,0 +1 @@
* The deprecated configuration variable ```SAMPLE_DATA_DIR``` has been removed in favour of user installation of the ```iris_sample_data``` package. No newline at end of file
Copy link
Contributor

@djkirkham djkirkham Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When installing via Conda, the package is called 'iris-sample-data', which is also the name of the GitHub repo.

@DPeterK DPeterK merged commit db473b1 into SciTools:master Oct 19, 2017
@QuLogic QuLogic added this to the v2.0.0 milestone Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djkirkham djkirkham djkirkham left review comments

@DPeterK DPeterK DPeterK approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@corinnebosley @DPeterK @djkirkham @QuLogic