Fix remaining skips #2809
Merged
Fix remaining skips #2809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2714
Closes #2808
Some things which need explaining:
For the GRIB tests, these were failing because they were trying to use
cube.fill_value. I've changed them to usecube.data.fill_valueinstead. This is actually counter to our masked data saving strategy, but I don't see any point fixing it here since we've moved everything to Iris-GRIB. The behaviour should be changed there.I've removed all the tests in
iris.tests.unit.fileformats.netcdf.test__load_cube.TestFillValue. Beforefill_valuewas added as a cube attribute, these tests were testing that the fill-value from the file was propagated onto the cube's_my_dataattribute, a Biggus array. In the current code there's no way to obtain the fill value from a cube with lazy data, and hence no way to test this behaviour. Arguably one could realise the data as part of the test to do so, but that just seems like testing the behaviour of Dask and NetCDF4-python.