-
Notifications
You must be signed in to change notification settings - Fork 300
removed CMAttribute and very old text file #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DPeterK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corinnebosley looks good 👍
|
@corinnebosley you haven't removed the unused imports from |
|
@dkillick So it turns out I pushed up the change you requested to the wrong branch, so I'll just make the same change to this one instead. I apparently also have to rebase... |
|
@dkillick No I don't. No rebasing necessary. I wonder where I saw that conflict message then... |
f043c2d to
396de0a
Compare
|
@dkillick I had messed up a couple of things in the confusing rebase, so I have tried to correct them now. I hope there's no other mistakes that I (and most of the tests, worryingly) have missed... |
|
Please GitHub, please please find my commit and tell Travis to run the tests on it... |
pelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This mosig codes text file used to be used for loading, but has not been used since 2013, just got left lying around dying slowly and painfully.
I'm putting it out of its misery. It's the kindest thing to do.
Also:
Closes #2670