Fix for pandas.as_dataframe when cube data array is a view #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelson
added
the
Blocked: CLA needed
pelson
removed
the
Blocked: CLA needed
Member
|
LGTM. Thanks @hdyson. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to convert an iris cube to a pandas dataframe currently fails if the
copy=Falseargument is used and the cube data is a view. The data is correctly shared between the cube and the dataframe. However, the check that the data is shared fails to account for the cube data being a view and throws an error. First commit here demonstrates the failure (error is thrown when creating the dataframe), and the second is the fix.I've not investigated why loading the data that triggered this error resulted in a cubelist where the individual cubes had a view for the data rather than the base array.