Fix concatenate tests #2737
Merged
Fix concatenate tests #2737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@djkirkham - are we still testing the ability to concatenate cubes of different dtypes? |
Contributor
Author
|
@pelson No, but following our offline discussion I'll re-add them |
Contributor
Author
|
@pelson Actually, it turns out we were never testing that. The tests that specify a dtype (the int16 ones) specify the same dtype for both cubes. |
Member
|
Do some result files need moving / removing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2715
I've initially reverted the file to how it was in version v1.13 since the file is now more similar to that version. I've then re-added tests which I thought still had value.