Remove Cube module deprecations #2695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Almost all of the Travis job failures are due to errors relating to the sudden absence of the 'regridded' attribute. The only exception is job 7370.1 which has a failed PEP8 conformity test. Job 7370.1 also has 2 TimeOutExceptions. |
Member
|
Wow there are a lot of tests that use Cube.regridded.... |
(cherry picked from commit b5b7b07)
DPeterK
force-pushed
the
remove_cube_regridded
branch
from
a517990 to
7259658
Compare
Member
|
@dkillick Looks like you've just got a pep8 failure because the test file 'iris.tests.test_coding_standards.TestCodeFormat' is still pointing to a file which isn't there any more. I found it on line 129 of that testing module. |
Member
Author
|
@corinnebosley let's hope this change gets the green tick for this PR! |
Member
Author
|
@corinnebosley woop another green tick! 😄 |
Member
|
Yayyy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the single deprecation in the Cube module:
cube.regridded.Fixes #2653 and replaces #2694