Skip to content

Conversation

@lbdreyer
Copy link
Member

@lbdreyer lbdreyer commented Jul 18, 2017

Fixes #2642
Fixes #2643
Fixes #2645

@lbdreyer lbdreyer added this to the v2.0 milestone Jul 18, 2017
@DPeterK
Copy link
Member

DPeterK commented Jul 19, 2017

@lbdreyer I've modified the description for this PR - you'd linked #2642 twice and I think the second link was supposed to point to #2645.

]
)
},
cmdclass={'test': SetupTestRunner, 'build_py': BuildPyWithExtras,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbdreyer I take it this is only used for pp-packing? Nothing else will be affected by the removal of this code section?

@corinnebosley
Copy link
Member

Pending clarification from @lbdreyer, I am happy to merge this. All changes look good and all tests pass.

@DPeterK DPeterK self-assigned this Oct 10, 2017
@DPeterK DPeterK merged commit b192fd8 into SciTools:master Oct 10, 2017
@pelson pelson mentioned this pull request Oct 18, 2017
@pelson
Copy link
Member

pelson commented Oct 18, 2017

Duped in #2363.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants