Skip to content

Remove pp deprecations #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corinnebosley merged 3 commits into from
Oct 10, 2017
Merged

Remove pp deprecations #2688

corinnebosley merged 3 commits into from
Oct 10, 2017

Conversation

@lbdreyer
Copy link
Member

@lbdreyer lbdreyer commented Jul 18, 2017 •
edited
Loading

Fixes #2647
Fixes #2648
Fixes #2649
Fixes #2668

This removes (almost!) all deprecations in iris/fileformats/pp.py. I didn't remove the class BitwiseInt as it being used (see #2646)

@lbdreyer lbdreyer added this to the v2.0 milestone Jul 18, 2017
@lbdreyer lbdreyer mentioned this pull request Jul 18, 2017
Closed
@DPeterK
Copy link
Member

DPeterK commented Jul 19, 2017

@lbdreyer you've missed a usage of as_pairs: it's used in a userguide saving example – we should probably update that example here to make use of the replacement function save_pairs_from_cube instead.

@DPeterK
Copy link
Member

DPeterK commented Jul 19, 2017 •
edited
Loading

@lbdreyer as I mentioned in a comment on #2646 I think we can remove the BitwiseInt class given the other changes going on here. You've also got a failing test that looks to be related to the deprecated functionality you've removed here...

Update: BitwiseInt is removed in #2776

@DPeterK DPeterK self-assigned this Oct 10, 2017
@DPeterK DPeterK requested a review from corinnebosley October 10, 2017 11:24
@corinnebosley corinnebosley merged commit b3f9fc7 into SciTools:master Oct 10, 2017
@lbdreyer lbdreyer deleted the pp_deps branch July 23, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corinnebosley corinnebosley corinnebosley approved these changes

Assignees

@DPeterK DPeterK

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lbdreyer @DPeterK @corinnebosley