Hash corrections #2173
Merged
Hash corrections #2173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running 128 parallel HEAD requests is overkill and liable to get someone banned.
marqh
reviewed
Oct 10, 2016
lib/iris/tests/test_image_json.py
Outdated
| else: | ||
| msg = '{} is not a valid resource.'.format(uri) | ||
| exceptions.append(ValueError(msg)) | ||
| continue |
Member
There was a problem hiding this comment.
what is the continue here for please, I am not convinced it is doing anything active
Member
Author
There was a problem hiding this comment.
Cut/paste leftover; will remove.
marqh
reviewed
Oct 10, 2016
|
|
||
| # maximum number of threads for multi-threading code | ||
| MAXTHREADS = 128 | ||
| MAXTHREADS = 8 |
Member
There was a problem hiding this comment.
this seems sensible, given your analysis of run times
marqh
reviewed
Oct 10, 2016
| try: | ||
| result = requests.head(resource) | ||
| if (result.status_code == 200 and | ||
| resource.startswith('https://scitools.github.io')): |
QuLogic
force-pushed
the
hash-corrections
branch
from
6b8ea39 to
87d1cf8
Compare
Member
|
neat improvements; thank you @QuLogic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to my comments on #2162. The number of threads does not need to be so high, and if the hostname is invalid, we should not even bother to make the request.