Skip to content

is_circular: grib load tests and what's new #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjlittle merged 5 commits into from
Oct 6, 2016
Merged

is_circular: grib load tests and what's new #2167

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b5136e
is_circular: grib load tests and what's new
marqh Oct 6, 2016
7fba15f
* not -
marqh Oct 6, 2016
354e585
wording
marqh Oct 6, 2016
72407eb
Update bugfix_2016-Oct-06_is_circular.txt
marqh Oct 6, 2016
dee81e4
Update bugfix_2016-Oct-06_is_circular.txt
marqh Oct 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/iris/src/whatsnew/contributions_1.11/bugfix_2016-Oct-06_is_circular.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
* Fixed a bug where :func:iris.util._is_circular would erroneously return False

@ajdawson ajdawson Oct 6, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markup here is no longer correct, it is missing the back-ticks ( I suspect because copy-paste from the Github comment, which turned the back-ticks into an object). You actually don't need to capitalise False in this usage unless you are referring explicitly to the Python object False...

when coordinate values are decreasing.
2 changes: 1 addition & 1 deletion lib/iris/tests/results/grib_load/ineg_jneg.cml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</dimCoord>
</coord>
<coord datadims="[1]">
<dimCoord id="160a738f" points="[356.249908, 352.49991, 348.749912, ...,
<dimCoord circular="True" id="160a738f" points="[356.249908, 352.49991, 348.749912, ...,
7.500094, 3.750096, 9.80000000368e-05]" shape="(96,)" standard_name="longitude" units="Unit('degrees')" value_type="float64">
<geogCS earth_radius="6367470.0"/>
</dimCoord>
Expand Down
2 changes: 1 addition & 1 deletion lib/iris/tests/results/grib_load/ineg_jpos.cml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</dimCoord>
</coord>
<coord datadims="[1]">
<dimCoord id="160a738f" points="[356.249908, 352.49991, 348.749912, ...,
<dimCoord circular="True" id="160a738f" points="[356.249908, 352.49991, 348.749912, ...,
7.500094, 3.750096, 9.80000000368e-05]" shape="(96,)" standard_name="longitude" units="Unit('degrees')" value_type="float64">
<geogCS earth_radius="6367470.0"/>
</dimCoord>
Expand Down