Check graphic hash #2161
Check graphic hash #2161
Conversation
Initial json repo of image hashes.
Incorporate json store check-graphic usage
Indented image json store.
Deal with multiple image hashes.
.travis.yml
Outdated
| script: | ||
| - if [[ $TEST_TARGET == 'default' ]]; then | ||
| python -m iris.tests.runner --default-tests --system-tests --print-failed-images; | ||
| python -m iris.tests.runner --default-tests --system-tests; |
There was a problem hiding this comment.
I think it could make sense to remove the support for the "print-failed-images" key from setup.py.
There was a problem hiding this comment.
for now i'm putting this back in; if it is removed then we can discuss removing the functionality too
lib/iris/tests/__init__.py
Outdated
| else: | ||
| # Cherry-pick the registered expected hashes from the | ||
| # test case uri/s. | ||
| expected = [] |
There was a problem hiding this comment.
I think a list comprehension would be clearer than init + append here.
Seems an obvious simplification of this code.
lib/iris/tests/__init__.py
Outdated
| # test case uri/s. | ||
| expected = [] | ||
| for uri in uris: | ||
| ehash = os.path.splitext(os.path.basename(uri))[0] |
There was a problem hiding this comment.
I'd still prefer that the url + hash were kept logically separate, and not insist that the filename "is" the hash.
The decision to do that may be enforced elsewhere, but better not to assume / require it here ?
|
replaced by #2162 |
|
It wasn't really necessary to open a new PR; just force push on this one. |
4 participants
No description provided.