BUG: as_pairs usage removal within iris

[cpelley]

Issue is here.

def as_fields(cube, field_coords=None, target=None):
    ...
-    return (field for cube, field in as_pairs(cube, field_coords=field_coords,
                                               target=target))
+    return (field for cube, field in save_pairs_from_cube(cube,
          field_coords=field_coords, target=target))

This means that our users are currently being issued a warning about using deprecated behaviour when they are not (made worse by the fact that warnings do not give a traceback).

[cpelley]

Tests pass, except the old issue of TimedOutException.

Cheers

[ajdawson]

Thanks @cpelley

[cpelley]

Thanks @ajdawson