Skip to content

Conversation

@djkirkham
Copy link
Contributor

Replaces uses of assertString in Pandas tests, one of which was failing due to a slight formatting change, with tests on the data.

@djkirkham djkirkham mentioned this pull request Sep 14, 2016
@marqh
Copy link
Member

marqh commented Sep 14, 2016

i think these test are maintaining test coverage whilst being more explicit about what is being tested in the test code

They also remove a fragility, exposed by a change to the pandas version and the way they choose to implement
str(iris.pandas.as_series(cube))
and change it in newer version of their library.
I don't think this is should be a test failure

I am very much minded to merge this as is

@marqh marqh merged commit c72959d into SciTools:master Sep 15, 2016
@QuLogic QuLogic added this to the v2.0 milestone Sep 15, 2016
@QuLogic QuLogic modified the milestones: v2.0, v1.11 Oct 7, 2016
@djkirkham djkirkham deleted the replace-pandas-tests branch October 26, 2017 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants