-
Notifications
You must be signed in to change notification settings - Fork 300
Py3k installable #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py3k installable #1701
Conversation
3c9f5db to
7cede6b
Compare
2e1649f to
5f5c0dd
Compare
c9a683c to
de057d7
Compare
de057d7 to
899d64f
Compare
|
This should be review-able now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we avoid using six here and just pass thumbnails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm not really bothered either way.
|
Thanks @QuLogic. I've only one real request which is that we keep the complexities of |
|
The examples are run as tests, so we'd need to be extra careful about their cross-compatibility. |
899d64f to
6054c9a
Compare
|
OK, your request has been handled. |
|
Wow, it took 10.5 minutes for that "Solving package specifications" step to finish. Is it because there are Python3 packages available now? |
These are syntax errors in Python 3 because a leading 0 signifies an alternate base where the second digit indicates the base.
6054c9a to
873bcaf
Compare
Does that include the time to actually download all 200MB of distributions? Solving and installing took 590s (~10mn) according to the travis log: |
|
In general I've found that the solving stage takes at least several minutes on my own machine when using the SciTools channel. This is way in excess of anything from the anaconda (default) channel. Is it because we only have packages for e.g. one version of numpy so it is more work for the solver to find a dependency solution? If so, can we do something about this? |
|
No, I was watching it. At 1min 1s, it had the first 6 or so dots, and at 11m 30s or so it moved on to "Package plan". (Note, I was referring to an older build there where the build+install phase is 712.82 s = 11.88 min) |
Interesting. Given the number of dependencies, we may be choking conda. Might be worth looking at splitting our install phase into multiple commands to reduce the resolve step. e.g. |
We have added the full matrix of possibilities to anaconda.org/scitools now though, so that wouldn't explain the performance found in the last week. @asmeurer - do you have any idea what might be slowing the conda resolution down on the scitools channel? Is it because some of our packages have a large number of dependencies, and the conda solver is choking? |
We deliberately moved away from multi-command installation because it was causing trouble with inconsistent numpy-version "ping-ponging". For example, |
And our recipes. Conda no longer bakes the numpy version into the run dependencies by default. Instead I'm proposing giving the solver less work todo by giving it an existing environment that it needs to fit into, but I have no idea if that would be of benefit to |
|
Installing sequentially is faster (e.g. 85 s) but still results in the "ping-pong" issue (e.g. https://travis-ci.org/rhattersley/iris/jobs/79175852#L334) which leads to https://travis-ci.org/rhattersley/iris/jobs/79175852#L804. |
|
The ping pong in this case looks like it is caused by us using a matplotlib which doesn't have a np18 build (we need to be aware that Continuum only build against the latest numpy and python 2/3 versions). Essentially, we just need to not do this naively and we will get the results we want (e.g. |
|
NB. Fixing either matplotlib to 1.3.1 or fixing numpy to 1.8 makes the dependency resolution painfully slow. If you have neither of those constraints the resolution is pretty much instant. |
Following up on #1699 and #1700, this one allows you to install on Python 3, i.e., you can run
python3 setup.py installand there won't be errors or warnings. Now, it doesn't actually run, but that's a bigger problem.Again, this looks huge since it's based on a couple previous ones. It's a little bit smaller than it looks right now.