Orca eg

[marqh]

new example for plotting ORCA data

[ajdawson]

There are some PEP8 errors causing the tests to fail. Also you need to add a test for the example itself, this is pretty straightforward, just follow the lead of the other examples. A side benefit of adding a test is that we'll be able to see the resulting plot in the PR which makes it easier to review.

[ajdawson]

Typo: PLateCarree -> PlateCarree

[ajdawson]

Typo: coordinate -> coordinate

[pp-mo]

I've only really just started on this, but given tweaks to data source noted in the diff I have got it to run + I see the resulting plot is really rather big.

I'm not sure this plays nicely to the gallery
(see what I did there 😀 ?!? - I mean http://scitools.org.uk/iris/docs/latest/gallery.html)
Maybe more seriously, it doesn't display nicely in the rendered html example page, either.
This is like the problem I had with the log-anomaly-plot example in an early version

• see : Added a custom colour plotting example. #1040 (comment)

Maybe you should consider separate figures for this reason -- you really need to play with building the docs + checking the results in a browser, and even experiment a bit with different window sizes and zooms. Tiresome, but unavoidable IMHO.

[marqh]

these are now four separate figures

[ajdawson]

Looks like you've only got one output file... did you mean to put plt.show() inside the loop?

[marqh]

Looks like you've only got one output file... did you mean to put plt.show() inside the loop?

meant to | should have done: done now anyhow

cheers

[esc24]

Please avoid variable names in all caps, it makes them look like constants. PC is a little cryptic too.

[bjlittle]

@marqh to ensure that the order of the tests run in the same order ...
for name in sorted(projections):

[marqh]

ok

[bjlittle]

@marqh You could slightly refactor this to be ...

    projections = dict(Mollweide=ccrs.Mollweide(),
                       PlateCarree=ccrs.PlateCarree(),
                       NorthPolarStereo=ccrs.NorthPolarStereo(),
                       Orthographic=ccrs.Orthographic(central_longitude=-90,
                                                      central_latitude=45))

[marqh]

@bjlittle
I'm afraid I don't see how this refactor makes the code any better/worse

[bjlittle]

Lovely example, thanks @marqh 👍